Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change asset-findings relationships rfc #1042

Merged
merged 5 commits into from
Feb 6, 2024
Merged

docs: change asset-findings relationships rfc #1042

merged 5 commits into from
Feb 6, 2024

Conversation

ramizpolic
Copy link
Member

@ramizpolic ramizpolic commented Dec 14, 2023 •
edited

Description

Proposes using many-to-many relationship between assets and findings to improve efficiency and achieve API consistency with the existing features.
This also enables feature-parity between VMClarity and KubeClarity findings.

Epic: #1041

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ramizpolic ramizpolic requested a review from a team as a code owner December 14, 2023 08:56
@ramizpolic ramizpolic marked this pull request as draft December 14, 2023 08:56
@ramizpolic ramizpolic mentioned this pull request Dec 14, 2023
Closed
7 tasks
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic ramizpolic self-assigned this Dec 16, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic ramizpolic changed the title docs: per-finding asset grouping proposal docs: one-to-many relationship between findings and its dependencies Jan 18, 2024
@ramizpolic ramizpolic changed the title docs: one-to-many relationship between findings and its dependencies docs: allow multiple assets in findings proposal Jan 18, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic ramizpolic added enhancement New feature or request component:api Issues related to API breaking change Pull Requests with breaking change rfc and removed component:api Issues related to API labels Jan 19, 2024
@ramizpolic ramizpolic marked this pull request as ready for review January 19, 2024 00:09
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic ramizpolic marked this pull request as draft January 22, 2024 23:36
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic ramizpolic force-pushed the rfc/asset-groups branch 2 times, most recently from 11c7b9e to 3af02f6 Compare January 28, 2024 20:23
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic ramizpolic marked this pull request as ready for review January 29, 2024 09:32
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic ramizpolic changed the title docs: allow multiple assets in findings proposal docs: change asset-findings relationships rfc Jan 29, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic
Copy link
Member Author

Ready for review 🙅

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
paralta
paralta previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 just a small remark

rfc/change-asset-findings-relationships.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1042-c303c412235330ddcce39e38dd02666499da4cbf
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1042-c303c412235330ddcce39e38dd02666499da4cbf
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1042-c303c412235330ddcce39e38dd02666499da4cbf
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1042-c303c412235330ddcce39e38dd02666499da4cbf
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1042-c303c412235330ddcce39e38dd02666499da4cbf
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1042-c303c412235330ddcce39e38dd02666499da4cbf

@ramizpolic ramizpolic added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit dab5c87 Feb 6, 2024
37 checks passed
@ramizpolic ramizpolic deleted the rfc/asset-groups branch February 6, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@paralta paralta paralta approved these changes

Assignees

@ramizpolic ramizpolic

Labels
breaking change Pull Requests with breaking change enhancement New feature or request rfc
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ramizpolic @chrisgacsal @paralta