Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: repo to work with local go.work file #1073

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

akijakya
Copy link
Contributor

@akijakya akijakya commented Jan 10, 2024

Description

Added go.work* files to gitignore, and docs how to use a go.work file in the repo.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[X] Documentation
[X] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

This comment has been minimized.

Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
@akijakya akijakya marked this pull request as ready for review January 16, 2024 13:38
@akijakya akijakya requested a review from a team as a code owner January 16, 2024 13:38
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1073-eefd121a6996aa760d91ea380925ad387b9e62d4
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1073-eefd121a6996aa760d91ea380925ad387b9e62d4
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1073-eefd121a6996aa760d91ea380925ad387b9e62d4
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1073-eefd121a6996aa760d91ea380925ad387b9e62d4
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1073-eefd121a6996aa760d91ea380925ad387b9e62d4

Copy link
Member

@lgecse lgecse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramizpolic ramizpolic added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 33c775e Jan 17, 2024
36 checks passed
@chrisgacsal chrisgacsal deleted the work-with-go-work branch January 17, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants