Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api): refactor scan estimation status api object #1089

Merged
merged 4 commits into from
Jan 12, 2024
Merged

refactor(api): refactor scan estimation status api object #1089

merged 4 commits into from
Jan 12, 2024

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jan 12, 2024 •
edited
Loading

Description

This PR refactors the status field of the ScanEstimation API object to be aligned with other objects.

discussion: #647

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added go Pull requests that update Go code component:api Issues related to API labels Jan 12, 2024
@adamtagscherer adamtagscherer self-assigned this Jan 12, 2024
@adamtagscherer adamtagscherer requested a review from a team as a code owner January 12, 2024 14:50
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
chrisgacsal
chrisgacsal reviewed Jan 12, 2024
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
paralta
paralta previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 let me know what you think of the comments/suggestions I left

api/openapi.yaml Outdated Show resolved Hide resolved
api/openapi.yaml Outdated Show resolved Hide resolved
api/openapi.yaml Outdated Show resolved Hide resolved
api/openapi.yaml Outdated Show resolved Hide resolved
pkg/apiserver/rest/scan_estimation_controller.go Show resolved Hide resolved
chrisgacsal
chrisgacsal previously approved these changes Jan 12, 2024
View reviewed changes
paralta
paralta reviewed Jan 12, 2024
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
paralta
paralta reviewed Jan 12, 2024
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
@chrisgacsal chrisgacsal self-requested a review January 12, 2024 16:03
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
chrisgacsal
chrisgacsal previously approved these changes Jan 12, 2024
View reviewed changes
paralta
paralta previously approved these changes Jan 12, 2024
View reviewed changes
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1089-d2d1ef16b08306e49d884c14b691986ac6b46c15
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1089-d2d1ef16b08306e49d884c14b691986ac6b46c15
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1089-d2d1ef16b08306e49d884c14b691986ac6b46c15
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1089-d2d1ef16b08306e49d884c14b691986ac6b46c15
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1089-d2d1ef16b08306e49d884c14b691986ac6b46c15

@adamtagscherer adamtagscherer added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 52aac54 Jan 12, 2024
33 checks passed
@adamtagscherer adamtagscherer deleted the scan-estimation-status-refactor branch January 12, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paralta paralta paralta approved these changes

@chrisgacsal chrisgacsal chrisgacsal left review comments

Assignees

@adamtagscherer adamtagscherer

Labels
component:api Issues related to API go Pull requests that update Go code
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamtagscherer @chrisgacsal @paralta