Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend client #110

Merged
merged 3 commits into from
Mar 8, 2023
Merged

backend client #110

merged 3 commits into from
Mar 8, 2023

Conversation

fishkerez
Copy link
Contributor

No description provided.

@fishkerez fishkerez requested a review from a user March 7, 2023 13:41
@fishkerez fishkerez self-assigned this Mar 7, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, we can merge this and do a follow up to fix the comments, or we can do one more iteration here.

}
return nil, ScanConflictError{
ConflictingScan: resp.JSON409.Scan,
Message: "conflict",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a message in the JSON409 that we can use here IIRC

@@ -1,4 +1,19 @@
package backend_client
// Copyright © 2022 Cisco Systems, Inc. and its affiliates.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2023

@fishkerez fishkerez merged commit be4a9f6 into main Mar 8, 2023
@fishkerez fishkerez deleted the backend-client-rebase branch March 8, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant