Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: multiple go modules rfc #1105

Merged
merged 5 commits into from
Jan 24, 2024
Merged

docs: multiple go modules rfc #1105

merged 5 commits into from
Jan 24, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Jan 18, 2024

Description

Add RFC to propose a new project structure which splits the main module into multiple modules to allow us to version modules separately and reduce dependencies.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta self-assigned this Jan 18, 2024
@paralta paralta added the documentation Improvements or additions to documentation label Jan 18, 2024
@paralta paralta force-pushed the multiple-go-modules-rfc branch 3 times, most recently from 69171b7 to c28a212 Compare January 18, 2024 15:05
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@openclarity openclarity deleted a comment from github-actions bot Jan 18, 2024
@openclarity openclarity deleted a comment from github-actions bot Jan 18, 2024
@openclarity openclarity deleted a comment from github-actions bot Jan 18, 2024
@openclarity openclarity deleted a comment from github-actions bot Jan 18, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta marked this pull request as ready for review January 19, 2024 09:12
@paralta paralta requested a review from a team as a code owner January 19, 2024 09:12
@paralta paralta force-pushed the multiple-go-modules-rfc branch 2 times, most recently from 4a70c83 to 694944a Compare January 19, 2024 11:37
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
lgecse
lgecse previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@lgecse lgecse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @paralta for putting this RFC together.

ramizpolic
ramizpolic previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

rfc/multiple-go-modules.md Show resolved Hide resolved
rfc/multiple-go-modules.md Outdated Show resolved Hide resolved
rfc/multiple-go-modules.md Outdated Show resolved Hide resolved
@paralta
Copy link
Contributor Author

paralta commented Jan 19, 2024

@ramizpolic @lgecse thank you so much for reviewing 😄

@paralta paralta dismissed stale reviews from ramizpolic and lgecse via b6872e9 January 19, 2024 14:20
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
lgecse
lgecse previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@lgecse lgecse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@ramizpolic ramizpolic self-requested a review January 19, 2024 15:14
ramizpolic
ramizpolic previously approved these changes Jan 19, 2024
View reviewed changes
@paralta paralta dismissed stale reviews from ramizpolic and lgecse via 599ab4c January 23, 2024 11:10
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1105-59784e04d830809834f5ec74696459de5e255c8f
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1105-59784e04d830809834f5ec74696459de5e255c8f
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1105-59784e04d830809834f5ec74696459de5e255c8f
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1105-59784e04d830809834f5ec74696459de5e255c8f
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1105-59784e04d830809834f5ec74696459de5e255c8f

chrisgacsal
chrisgacsal approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job @paralta!

@paralta paralta added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 4dc83c8 Jan 24, 2024
33 checks passed
@paralta paralta deleted the multiple-go-modules-rfc branch January 24, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@ramizpolic ramizpolic ramizpolic left review comments

@lgecse lgecse lgecse left review comments

Assignees

@paralta paralta

Labels
documentation Improvements or additions to documentation rfc
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paralta @chrisgacsal @ramizpolic @lgecse