Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): don't return error if home dir doesn't exist #1107

Merged
merged 3 commits into from
Jan 19, 2024
Merged

fix(cli): don't return error if home dir doesn't exist #1107

merged 3 commits into from
Jan 19, 2024

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jan 18, 2024 •
edited

Description

This PR fixes the sshTopology scanner's error, that failed when there was no home directory in the scanned filesystem.

before:
Screenshot 2024-01-17 at 12 40 49

after:
Screenshot 2024-01-18 at 21 21 00

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer self-assigned this Jan 18, 2024
@adamtagscherer adamtagscherer added the go Pull requests that update Go code label Jan 18, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@adamtagscherer adamtagscherer marked this pull request as ready for review January 19, 2024 09:03
@adamtagscherer adamtagscherer requested a review from a team as a code owner January 19, 2024 09:03
chrisgacsal
chrisgacsal approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1107-8dc86d9ef7d0f8d1740b58f61618057e25b6f43e
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1107-8dc86d9ef7d0f8d1740b58f61618057e25b6f43e
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1107-8dc86d9ef7d0f8d1740b58f61618057e25b6f43e
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1107-8dc86d9ef7d0f8d1740b58f61618057e25b6f43e
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1107-8dc86d9ef7d0f8d1740b58f61618057e25b6f43e

@adamtagscherer adamtagscherer added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 6400bc5 Jan 19, 2024
33 checks passed
@adamtagscherer adamtagscherer deleted the fix-ssh-scanner branch January 19, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@ramizpolic ramizpolic ramizpolic approved these changes

Assignees

@adamtagscherer adamtagscherer

Labels
go Pull requests that update Go code
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamtagscherer @chrisgacsal @ramizpolic