-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docker bake #1111
Merged
Merged
feat: add docker bake #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75007c6
to
bfa98a4
Compare
This comment has been minimized.
This comment has been minimized.
bfa98a4
to
77c8810
Compare
This comment has been minimized.
This comment has been minimized.
77c8810
to
f71e8a8
Compare
This comment has been minimized.
This comment has been minimized.
99e8ded
to
333b285
Compare
This comment has been minimized.
This comment has been minimized.
333b285
to
be50d64
Compare
This comment has been minimized.
This comment has been minimized.
be50d64
to
df2dcb9
Compare
This comment has been minimized.
This comment has been minimized.
df2dcb9
to
c1ec1f4
Compare
This comment has been minimized.
This comment has been minimized.
c1ec1f4
to
1011bee
Compare
This comment has been minimized.
This comment has been minimized.
1011bee
to
1f5ab26
Compare
This comment has been minimized.
This comment has been minimized.
da42bee
to
dacb6dd
Compare
This comment has been minimized.
This comment has been minimized.
64b55bd
to
b1d7dde
Compare
This comment has been minimized.
This comment has been minimized.
b1d7dde
to
ab1e200
Compare
This comment has been minimized.
This comment has been minimized.
ramizpolic
requested changes
Jan 29, 2024
d913f9f
to
fc81bfe
Compare
This comment has been minimized.
This comment has been minimized.
chrisgacsal
requested changes
Feb 2, 2024
Signed-off-by: András Jáky <ajaky@cisco.com>
fc81bfe
to
4980331
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: András Jáky <ajaky@cisco.com>
4980331
to
63d39ad
Compare
Hey! Your images are ready:
|
ramizpolic
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested make & bake and it works properly now, thanks @akijakya!
chrisgacsal
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Docker Bake to streamline docker builds, also modified the Makefile use bake for building and pushing images to the repository.
Modifying the CI will come in another PR.
Build time remained the same, but using Docker Bake comes with some advantages:
modularity 🧱
docker-bake.hcl
with thecontext
anddockerfile
fieldstidiness ✨
Fixes #1085
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist