Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add label to ContainerInfo detail page #1136

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat(ui): add label to ContainerInfo detail page #1136

merged 1 commit into from
Jan 30, 2024

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jan 30, 2024 •
edited

Description

Added the labels of a container to the ContainerInfo details page on the UI.

before:

Screenshot 2024-01-30 at 12 39 54

after:

Screenshot 2024-01-30 at 12 36 50

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added javascript Pull requests that update Javascript code component:ui Issues related to UI/Frontend labels Jan 30, 2024
@adamtagscherer adamtagscherer self-assigned this Jan 30, 2024
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1136-3422bc6cf1a4fe974f468775f31e4911f2db9911
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1136-3422bc6cf1a4fe974f468775f31e4911f2db9911
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1136-3422bc6cf1a4fe974f468775f31e4911f2db9911
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1136-3422bc6cf1a4fe974f468775f31e4911f2db9911
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1136-3422bc6cf1a4fe974f468775f31e4911f2db9911

@adamtagscherer adamtagscherer marked this pull request as ready for review January 30, 2024 11:59
@adamtagscherer adamtagscherer requested a review from a team as a code owner January 30, 2024 11:59
chrisgacsal
chrisgacsal approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the fix! :shipit:

@adamtagscherer adamtagscherer added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit d1df624 Jan 30, 2024
38 checks passed
@adamtagscherer adamtagscherer deleted the add-label-to-container-detail-page branch January 30, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@adamtagscherer adamtagscherer

Labels
component:ui Issues related to UI/Frontend javascript Pull requests that update Javascript code
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamtagscherer @chrisgacsal