Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): abort scan from the ui #1141

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix(ui): abort scan from the ui #1141

merged 1 commit into from
Jan 31, 2024

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jan 31, 2024 •
edited

Description

Currently JavaScript PATCH-es a badly formatted body for aborting a Scan, this PR fixes this.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added javascript Pull requests that update Javascript code component:ui Issues related to UI/Frontend labels Jan 31, 2024
@adamtagscherer adamtagscherer self-assigned this Jan 31, 2024
@adamtagscherer adamtagscherer requested a review from a team as a code owner January 31, 2024 13:28
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1141-fcabbefdb2dab8b6b52d4668fd800b9e1614b6fd
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1141-fcabbefdb2dab8b6b52d4668fd800b9e1614b6fd
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1141-fcabbefdb2dab8b6b52d4668fd800b9e1614b6fd
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1141-fcabbefdb2dab8b6b52d4668fd800b9e1614b6fd
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1141-fcabbefdb2dab8b6b52d4668fd800b9e1614b6fd

chrisgacsal
chrisgacsal approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix! :shipit:

@adamtagscherer adamtagscherer added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit e143b69 Jan 31, 2024
38 checks passed
@adamtagscherer adamtagscherer deleted the fix-abort-scan-from-ui branch January 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@adamtagscherer adamtagscherer

Labels
component:ui Issues related to UI/Frontend javascript Pull requests that update Javascript code
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamtagscherer @chrisgacsal