ci: use Docker Bake for build and push #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
akijakya
force-pushed
the
ci-use-bake-for-builds
branch
from
59697d2
to
301a6ab
Compare
This comment has been minimized.
This comment has been minimized.
ramizpolic
previously approved these changes
Feb 9, 2024
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
akijakya
force-pushed
the
ci-use-bake-for-builds
branch
from
301a6ab
to
4ed2642
Compare
|
Hey! Your images are ready:
|
chrisgacsal
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Docker Bake for build and push workflows.
Build and push is now image name agnostic, meaning that it only takes a
bake groupname as input and builds the target images defined in the group as long as the bake target name is the same as the image name. Thereusable-build-and-pushnow splits the bake group into its targets and builds them in a matrix with thebuild-and-push-component, which also builds the target in a matrix of the defined platforms.As a result of this, the image names are not calculated beforehand, instead, they are the output of the bake action, so only parts from
reusable-image-names.ymlwere used instead of the workflow itself in this build process (I kept it for thereusable-end-to-end-testingworkflow but I think those two now could also be merged). Also, image names are uploaded as artifacts for other jobs to use.Fixes #1157
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist