Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach volume after running #119

Merged
3 commits merged into from
Mar 10, 2023
Merged

attach volume after running #119

3 commits merged into from
Mar 10, 2023

Conversation

fishkerez
Copy link
Contributor

No description provided.

@fishkerez fishkerez requested a review from FrimIdan March 8, 2023 15:28
@fishkerez fishkerez self-assigned this Mar 8, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, a couple of comments about placement of the code, and about permissions in the cloud formation.

installation/aws/VmClarity.cfn Show resolved Hide resolved
runtime_scan/pkg/provider/aws/client.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/aws/client.go Outdated Show resolved Hide resolved
runtime_scan/pkg/provider/aws/client.go Outdated Show resolved Hide resolved
@fishkerez fishkerez requested a review from a team as a code owner March 9, 2023 17:37
@ghost ghost force-pushed the attach-after-run-rebase-2 branch from a421756 to 82341a1 Compare March 10, 2023 09:39
runtime_scan/pkg/provider/aws/volume.go Outdated Show resolved Hide resolved
runtime_scan/pkg/scanner/job_managment.go Outdated Show resolved Hide resolved
@ghost ghost merged commit 5ea04fb into main Mar 10, 2023
@chrisgacsal chrisgacsal deleted the attach-after-run-rebase-2 branch October 2, 2023 19:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants