Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows registry sbom analyzer #1196

Merged
merged 12 commits into from
Feb 9, 2024
Merged

Conversation

ramizpolic
Copy link
Member

@ramizpolic ramizpolic commented Feb 8, 2024

Description

Adds a new platform-independent analyzer capable of extracting SBOM data from the offline Windows registry. Works for the majority of Windows NT distros and fully tested against Windows Vista and upwards. Supports scanning rootfs, dir, and file inputs.

Links: #1204

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

This comment has been minimized.

This comment has been minimized.

@ramizpolic ramizpolic self-assigned this Feb 8, 2024
@ramizpolic ramizpolic added scanners Issues related to adding new scanners enhancement New feature or request labels Feb 8, 2024

This comment has been minimized.

@ramizpolic ramizpolic added the go Pull requests that update Go code label Feb 8, 2024
@ramizpolic ramizpolic marked this pull request as ready for review February 8, 2024 22:07
@ramizpolic ramizpolic requested a review from a team as a code owner February 8, 2024 22:07

This comment has been minimized.

@ramizpolic ramizpolic force-pushed the feat/windows-scanner branch 3 times, most recently from 1135bf6 to fd6cab6 Compare February 9, 2024 10:13

This comment has been minimized.

cli/analyzer/windows/registry.go Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the effort! :shipit:

Copy link

github-actions bot commented Feb 9, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1196-ad7b41c9f035ab3eb6ea9502be8fa31ad2225fda
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1196-ad7b41c9f035ab3eb6ea9502be8fa31ad2225fda
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1196-ad7b41c9f035ab3eb6ea9502be8fa31ad2225fda
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1196-ad7b41c9f035ab3eb6ea9502be8fa31ad2225fda
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1196-ad7b41c9f035ab3eb6ea9502be8fa31ad2225fda
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1196-ad7b41c9f035ab3eb6ea9502be8fa31ad2225fda

@ramizpolic ramizpolic added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit cdd7678 Feb 9, 2024
37 checks passed
@ramizpolic ramizpolic deleted the feat/windows-scanner branch February 9, 2024 22:22
@ramizpolic ramizpolic mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code scanners Issues related to adding new scanners
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants