Fix AWS Scope API model validation and regions logic #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishkerez
previously approved these changes
Mar 9, 2023
ghost
force-pushed
the
revisit_aws_scope
branch
2 times, most recently
from
5910110
to
8002149
Compare
akpsgit
reviewed
Mar 9, 2023
akpsgit
reviewed
Mar 9, 2023
akpsgit
reviewed
Mar 9, 2023
akpsgit
reviewed
Mar 9, 2023
akpsgit
reviewed
Mar 9, 2023
akpsgit
reviewed
Mar 9, 2023
akpsgit
reviewed
Mar 9, 2023
ghost
force-pushed
the
revisit_aws_scope
branch
from
8002149
to
b13a9cb
Compare
This commit fixes the validation of the AWSScope type so that if you provide invalid properties or miss some required properties it errors. It renames the "all" field to "allRegions" which better describes what the flag does.
ghost
force-pushed
the
revisit_aws_scope
branch
from
b13a9cb
to
03f0271
Compare
akpsgit
approved these changes
Mar 10, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the validation of the AWSScope type so that if you provide invalid properties or miss some required properties it errors.
It also removes the "all" field from the AWSScope in favor of "No regions" == "All Regions" logic.