ci: fix success check #1280
Merged
ci: fix success check #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The success is skipped instead of failed when depending jobs defined in needs parameter are skipped/failed. Skipped success job threated the same way as if it was successful therefore CI proceeds with merging PRs in case auto-merge is enabled.
paralta
approved these changes
Feb 14, 2024
|
Hey! Your images are ready:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
successis skipped instead of failed when depending jobs defined inneedsparameter are skipped/failed. Skippedsuccessjob treated the same way as if it was successful therefore CI proceeds with merging Pull Request in case it has auto-merge enabled.Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[x] Other (please describe)
Checklist