Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for $orderby #129

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Add support for $orderby #129

merged 3 commits into from
Mar 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2023

Also fixes a $select bug on nested collections, and refactors odatasql to reduce the complexity of the buildSelectFields function.

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

[x] Bug Fix
[x] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ghost ghost self-requested a review as a code owner March 13, 2023 15:18
Also fixes a $select bug on nested collections, and refactors odatasql
to reduce the complexity of the buildSelectFields function.
akpsgit
akpsgit previously approved these changes Mar 13, 2023
@akpsgit akpsgit merged commit b31b6dc into main Mar 13, 2023
@chrisgacsal chrisgacsal deleted the orderby branch October 2, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants