Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: push multiarch images #1320

Merged
merged 2 commits into from
Feb 20, 2024
Merged

build: push multiarch images #1320

merged 2 commits into from
Feb 20, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Feb 20, 2024 •
edited

Description

  • Add bake option to push multiarch images
  • Remove push-docker target and replace it with a DOCKER_PUSH var

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner February 20, 2024 10:10
@paralta paralta self-assigned this Feb 20, 2024
@paralta paralta added the build label Feb 20, 2024
akijakya
akijakya previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

chrisgacsal
chrisgacsal previously approved these changes Feb 20, 2024
View reviewed changes
@paralta paralta dismissed stale reviews from chrisgacsal and akijakya via 653d4ae February 20, 2024 10:18
akijakya
akijakya previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
chrisgacsal
chrisgacsal previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

akijakya
akijakya previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@paralta paralta dismissed stale reviews from akijakya and chrisgacsal via 3049a15 February 20, 2024 10:49
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1320-4d13e613073fffae715149d7d7e81e73be6bbb8a
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1320-4d13e613073fffae715149d7d7e81e73be6bbb8a
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1320-4d13e613073fffae715149d7d7e81e73be6bbb8a
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1320-4d13e613073fffae715149d7d7e81e73be6bbb8a
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1320-4d13e613073fffae715149d7d7e81e73be6bbb8a
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1320-4d13e613073fffae715149d7d7e81e73be6bbb8a

@paralta paralta added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit 97ebc74 Feb 20, 2024
36 checks passed
@paralta paralta deleted the push-multiarch branch February 20, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@akijakya akijakya Awaiting requested review from akijakya

Assignees

@paralta paralta

Labels
build
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paralta @chrisgacsal @akijakya