Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename asset to target in cloud init #1382

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: rename asset to target in cloud init #1382

merged 1 commit into from
Feb 29, 2024

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Feb 29, 2024 •
edited

Description

This PR renames the network.asset to network.target and the multi-user.asset to multi-user.target in the cloud init files.

PR where this regression was introduced: #282

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added bug Something isn't working infrastructure Issues related to VMClarity control plane infrastructure labels Feb 29, 2024
@adamtagscherer adamtagscherer self-assigned this Feb 29, 2024
@adamtagscherer adamtagscherer requested a review from a team as a code owner February 29, 2024 08:25
chrisgacsal
chrisgacsal approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks a lot for fixing this! :shipit:

@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1382-536e4ee01dd088c6de29b5a90fc667f2ea45cdf1
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1382-536e4ee01dd088c6de29b5a90fc667f2ea45cdf1
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1382-536e4ee01dd088c6de29b5a90fc667f2ea45cdf1
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1382-536e4ee01dd088c6de29b5a90fc667f2ea45cdf1
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1382-536e4ee01dd088c6de29b5a90fc667f2ea45cdf1
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1382-536e4ee01dd088c6de29b5a90fc667f2ea45cdf1

@adamtagscherer adamtagscherer added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit ca538f8 Feb 29, 2024
37 checks passed
@adamtagscherer adamtagscherer deleted the fix-network-init-process branch February 29, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@adamtagscherer adamtagscherer

Labels
bug Something isn't working infrastructure Issues related to VMClarity control plane infrastructure
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamtagscherer @chrisgacsal