Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix build tags for go vet and test #1407

Merged
merged 1 commit into from
Mar 6, 2024
Merged

build: fix build tags for go vet and test #1407

merged 1 commit into from
Mar 6, 2024

Conversation

chrisgacsal
Copy link
Contributor

Description

Fix passing Go build tags properly for Make targets running go vet and go test.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[x] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner March 5, 2024 07:13
@chrisgacsal chrisgacsal self-assigned this Mar 5, 2024
akijakya
akijakya previously approved these changes Mar 5, 2024
View reviewed changes
adamtagscherer
adamtagscherer previously approved these changes Mar 6, 2024
View reviewed changes
@chrisgacsal chrisgacsal dismissed stale reviews from adamtagscherer and akijakya via f23bf79 March 6, 2024 20:02
@chrisgacsal chrisgacsal force-pushed the fix-build-tags branch 2 times, most recently from c417067 to 572339c Compare March 6, 2024 20:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1407-405f026162bb5bd98af2549b6f7f1c56e5904eb4
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1407-405f026162bb5bd98af2549b6f7f1c56e5904eb4
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1407-405f026162bb5bd98af2549b6f7f1c56e5904eb4
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1407-405f026162bb5bd98af2549b6f7f1c56e5904eb4
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1407-405f026162bb5bd98af2549b6f7f1c56e5904eb4
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1407-405f026162bb5bd98af2549b6f7f1c56e5904eb4

@chrisgacsal chrisgacsal added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit bb2ffef Mar 6, 2024
41 of 42 checks passed
@chrisgacsal chrisgacsal deleted the fix-build-tags branch March 6, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamtagscherer adamtagscherer adamtagscherer approved these changes

@akijakya akijakya Awaiting requested review from akijakya

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisgacsal @adamtagscherer @akijakya