Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race condition in workflow #1417

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: race condition in workflow #1417

merged 1 commit into from
Mar 6, 2024

Conversation

chrisgacsal
Copy link
Contributor

Description

Fix race condition where certain cases goroutine is able to send task update to closed channel.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner March 6, 2024 05:31
@chrisgacsal chrisgacsal self-assigned this Mar 6, 2024
@chrisgacsal chrisgacsal added the bug Something isn't working label Mar 6, 2024
@chrisgacsal chrisgacsal changed the title fix: race condition fix: race condition in workflow Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1417-8f60b448c9a470a0f73505508db508694c4401cb
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1417-8f60b448c9a470a0f73505508db508694c4401cb
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1417-8f60b448c9a470a0f73505508db508694c4401cb
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1417-8f60b448c9a470a0f73505508db508694c4401cb
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1417-8f60b448c9a470a0f73505508db508694c4401cb
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1417-8f60b448c9a470a0f73505508db508694c4401cb

@chrisgacsal chrisgacsal added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit b96f928 Mar 6, 2024
35 checks passed
@chrisgacsal chrisgacsal deleted the fix-race-cond-in-workflow branch March 6, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamtagscherer adamtagscherer adamtagscherer approved these changes

Assignees

@chrisgacsal chrisgacsal

Labels
bug Something isn't working
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisgacsal @adamtagscherer