Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Azure providerv2 with workflow #1419

Closed
wants to merge 2 commits into from

Conversation

akijakya
Copy link
Contributor

@akijakya akijakya commented Mar 6, 2024

Description

WIP

On the tasks front it needs some more refactoring, i.e. RemoveAssetScan tasks could be defined on their own so their dependencies could be configured independently etc.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@akijakya akijakya self-assigned this Mar 6, 2024
@akijakya akijakya added the no-stale Marks an issue so that it never goes stale. label Mar 6, 2024
@akijakya akijakya force-pushed the azure-providerv2-with-workflow branch 2 times, most recently from aee2c80 to f9427f2 Compare March 8, 2024 12:54

This comment has been minimized.

@akijakya akijakya force-pushed the azure-providerv2-with-workflow branch 2 times, most recently from d566498 to 4db2a75 Compare May 30, 2024 14:25
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
@akijakya akijakya force-pushed the azure-providerv2-with-workflow branch from 4db2a75 to 65332cd Compare June 5, 2024 11:41
Copy link

github-actions bot commented Jun 5, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1419-554b77ddc8db4c39f5d26d204e2a1f1207aa265b
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1419-554b77ddc8db4c39f5d26d204e2a1f1207aa265b
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1419-554b77ddc8db4c39f5d26d204e2a1f1207aa265b
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1419-554b77ddc8db4c39f5d26d204e2a1f1207aa265b
  • ghcr.io/openclarity/vmclarity-plugin-kics-dev:pr1419-554b77ddc8db4c39f5d26d204e2a1f1207aa265b
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1419-554b77ddc8db4c39f5d26d204e2a1f1207aa265b
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1419-554b77ddc8db4c39f5d26d204e2a1f1207aa265b

@ramizpolic
Copy link
Member

@akijakya can we close/delete this one or should we preserve?

@akijakya
Copy link
Contributor Author

akijakya commented Aug 9, 2024

@akijakya can we close/delete this one or should we preserve?

The PR can be closed but the branch could be migrated for future reference!

@ramizpolic ramizpolic closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale Marks an issue so that it never goes stale.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants