Fix PATCH behaviour and nil pointer issues in configwatcher #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrimIdan
reviewed
Mar 16, 2023
fishkerez
reviewed
Mar 16, 2023
ghost
force-pushed
the
fix_configwatcher_scan_check
branch
from
44205a8
to
e98497e
Compare
FrimIdan
previously approved these changes
Mar 16, 2023
FrimIdan
previously approved these changes
Mar 16, 2023
Also adds a default to the errors field to ensure that we're consistent when errors is not provided gets stored as an empty list.
This causes the scan and target to cleared when TargetScanResult is PATCHed.
ghost
force-pushed
the
fix_configwatcher_scan_check
branch
from
28cf19e
to
38312c8
Compare
pbalogh-sa
approved these changes
Mar 17, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PATCH is current acting like PUT and unspecified fields will get deleted by PATCH instead of ignored. This identified missing nil checks in the configwatcher which have also been fixed.
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist