Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add healthz checks to cloudformation template #1481

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Mar 20, 2024

Description

Add healthchecks to the docker compose file in the Cloudformation template to make it consistent with https://github.com/openclarity/vmclarity/blob/main/installation/docker/docker-compose.yml.

Tested on AWS ✅

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner March 20, 2024 11:34
@paralta paralta self-assigned this Mar 20, 2024
@paralta paralta added the provider:aws Issues relating to the AWS provider label Mar 20, 2024

This comment has been minimized.

This comment has been minimized.

chrisgacsal
chrisgacsal previously approved these changes Mar 21, 2024
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1481-0b75acf674dab45e203ec1d6f80247301f3670c8
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1481-0b75acf674dab45e203ec1d6f80247301f3670c8
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1481-0b75acf674dab45e203ec1d6f80247301f3670c8
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1481-0b75acf674dab45e203ec1d6f80247301f3670c8
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1481-0b75acf674dab45e203ec1d6f80247301f3670c8
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1481-0b75acf674dab45e203ec1d6f80247301f3670c8

@paralta paralta added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit df2f928 Mar 21, 2024
34 checks passed
@paralta paralta deleted the aws-compose-healthz branch March 21, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:aws Issues relating to the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants