Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nil pointer error if ContainerImageInfo.Id field is not set #1500

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: Nil pointer error if ContainerImageInfo.Id field is not set #1500

merged 1 commit into from
Mar 26, 2024

Conversation

csatib02
Copy link
Member

Description

  • Added a check if asset.Id is nil or empty, a 400 bad request error is returned.

Fixes: #707

Type of Change

[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@csatib02
fix(gorm/asset.go): nil pointer error
22ed4ba 
Signed-off-by: Bence Csati <bcsati@cisco.com>

fix(gorm/asset.go): nil pointer error

Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 added bug Something isn't working go Pull requests that update Go code component:api Issues related to API labels Mar 25, 2024
@csatib02 csatib02 self-assigned this Mar 25, 2024
@csatib02 csatib02 requested a review from a team as a code owner March 25, 2024 11:01
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1500-2f3f344d0dbba96e5398e46a2b9356a919a71411
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1500-2f3f344d0dbba96e5398e46a2b9356a919a71411
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1500-2f3f344d0dbba96e5398e46a2b9356a919a71411
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1500-2f3f344d0dbba96e5398e46a2b9356a919a71411
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1500-2f3f344d0dbba96e5398e46a2b9356a919a71411
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1500-2f3f344d0dbba96e5398e46a2b9356a919a71411

chrisgacsal
chrisgacsal approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@csatib02 csatib02 added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 80a9fa1 Mar 26, 2024
34 checks passed
@csatib02 csatib02 deleted the fix/nil-pointer-error-if-ContainerImageInfoID-is-not-set branch March 26, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@csatib02 csatib02

Labels
bug Something isn't working component:api Issues related to API go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nil pointer error if ContainerImageInfo.ID is not set
2 participants
@csatib02 @chrisgacsal