Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: healthchecks in Azure installer, names for VMClarity roles #1503

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

akijakya
Copy link
Contributor

@akijakya akijakya commented Mar 26, 2024

Description

  • added healthchecks to VMClarity containers started during Azure installation
  • added human readable names to roles that are created during Azure installation so they could be identified better on Azure console

Type of Change

[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@akijakya akijakya added the installer:azure Issues relating to the Azure installation logic label Mar 26, 2024
@akijakya akijakya self-assigned this Mar 26, 2024
@akijakya akijakya requested a review from a team as a code owner March 26, 2024 09:26

This comment has been minimized.

paralta
paralta previously approved these changes Mar 27, 2024

This comment has been minimized.

Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
@akijakya akijakya force-pushed the azure-installation-healthchecks branch from 1bf1814 to b916e9e Compare March 27, 2024 12:52
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1503-2c7d098debcc2300c428816d0b9a5af1c04420e7
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1503-2c7d098debcc2300c428816d0b9a5af1c04420e7
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1503-2c7d098debcc2300c428816d0b9a5af1c04420e7
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1503-2c7d098debcc2300c428816d0b9a5af1c04420e7
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1503-2c7d098debcc2300c428816d0b9a5af1c04420e7
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1503-2c7d098debcc2300c428816d0b9a5af1c04420e7

@akijakya akijakya added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit efff898 Mar 27, 2024
34 checks passed
@akijakya akijakya deleted the azure-installation-healthchecks branch March 27, 2024 15:41
ramizpolic pushed a commit that referenced this pull request Apr 7, 2024
* feat: container healthchecks in Azure installer

Signed-off-by: András Jáky <ajaky@cisco.com>

* feat: human readable names to VMClarity roles

Signed-off-by: András Jáky <ajaky@cisco.com>

* chore: make gen-bicep

Signed-off-by: András Jáky <ajaky@cisco.com>

---------

Signed-off-by: András Jáky <ajaky@cisco.com>
ramizpolic added a commit that referenced this pull request Apr 7, 2024
commit 5f7948e
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Fri Apr 5 13:03:10 2024 +0100

    feat: implement export results (in progress)

commit 9e435be
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Fri Apr 5 10:00:42 2024 +0100

    feat: parse plugin scanner outputs

commit ec15979
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Thu Apr 4 17:14:58 2024 +0100

    feat: add plugin output type

commit 19d7c6f
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Thu Apr 4 17:00:24 2024 +0100

    feat: implement job registration

commit 9efa892
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Thu Apr 4 16:15:50 2024 +0100

    feat: add name to new job

commit aa71d33
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Thu Apr 4 13:52:31 2024 +0100

    feat: implement plugins runner

commit 5619c68
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Thu Apr 4 11:15:15 2024 +0100

    feat: implement plugins family run

commit 5947a22
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Wed Mar 27 18:04:23 2024 +0000

    feat(plugin): add plugin configuration to api spec

commit 3e2bc11
Author: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Date:   Wed Mar 27 17:08:49 2024 +0000

    feat(plugin): create plugin configuration

commit 78141ab
Author: András Jáky <ajaky@cisco.com>
Date:   Wed Mar 27 17:10:48 2024 +0100

    init

    Signed-off-by: András Jáky <ajaky@cisco.com>

commit efff898
Author: András Jáky <ajaky@cisco.com>
Date:   Wed Mar 27 16:15:53 2024 +0100

    feat: healthchecks in Azure installer, names for VMClarity roles (#1503)

    * feat: container healthchecks in Azure installer

    Signed-off-by: András Jáky <ajaky@cisco.com>

    * feat: human readable names to VMClarity roles

    Signed-off-by: András Jáky <ajaky@cisco.com>

    * chore: make gen-bicep

    Signed-off-by: András Jáky <ajaky@cisco.com>

    ---------

    Signed-off-by: András Jáky <ajaky@cisco.com>

commit fd9620c
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Mar 27 11:30:38 2024 +0000

    fix(deps): update module github.com/aquasecurity/trivy to v0.50.1 (#1509)

    * fix(deps): update module github.com/aquasecurity/trivy to v0.50.1

    * fix: go mod tidy

    ---------

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Catarina Paralta <46568597+paralta@users.noreply.github.com>

commit 32731cb
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Mar 27 11:27:28 2024 +0000

    chore(deps): update docker.io/aquasec/trivy docker tag to v0.50.1 (#1508)

    * chore(deps): update docker.io/aquasec/trivy docker tag to v0.50.1

    * docs: update helm docs

    ---------

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Catarina Paralta <46568597+paralta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer:azure Issues relating to the Azure installation logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants