Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add OS signal handling #1543

Merged
merged 1 commit into from
Apr 9, 2024
Merged

feat(cli): add OS signal handling #1543

merged 1 commit into from
Apr 9, 2024

Conversation

chrisgacsal
Copy link
Contributor

Description

Add OS signal handling to cli so process shutdown triggered by SIGINT, SIGHUP, etc are handled gracefully.

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner April 8, 2024 18:06
@chrisgacsal chrisgacsal self-assigned this Apr 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1543-c2ec6d001bfa65f2bc1cbfb6e35cd42760a7eb80
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1543-c2ec6d001bfa65f2bc1cbfb6e35cd42760a7eb80
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1543-c2ec6d001bfa65f2bc1cbfb6e35cd42760a7eb80
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1543-c2ec6d001bfa65f2bc1cbfb6e35cd42760a7eb80
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1543-c2ec6d001bfa65f2bc1cbfb6e35cd42760a7eb80
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1543-c2ec6d001bfa65f2bc1cbfb6e35cd42760a7eb80

@chrisgacsal chrisgacsal added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 2546c37 Apr 9, 2024
36 checks passed
@chrisgacsal chrisgacsal deleted the add-signal-handling branch April 9, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgecse lgecse lgecse approved these changes

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisgacsal @lgecse