Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error returned by mount #1555

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: error returned by mount #1555

merged 1 commit into from
Apr 11, 2024

Conversation

chrisgacsal
Copy link
Contributor

Description

Fix custom error returned by mount.Mount and mount.Umount functions in utils/fsutils/mount pkg which returned the error by value instead of pointer.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner April 11, 2024 10:08
@chrisgacsal chrisgacsal self-assigned this Apr 11, 2024
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1555-8c980a83f220310b355f0a01c3b695a9ede9f113
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1555-8c980a83f220310b355f0a01c3b695a9ede9f113
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1555-8c980a83f220310b355f0a01c3b695a9ede9f113
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1555-8c980a83f220310b355f0a01c3b695a9ede9f113
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1555-8c980a83f220310b355f0a01c3b695a9ede9f113
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1555-8c980a83f220310b355f0a01c3b695a9ede9f113

@chrisgacsal chrisgacsal added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 4c050d0 Apr 11, 2024
34 checks passed
@chrisgacsal chrisgacsal deleted the fix-mount-err branch April 11, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgecse lgecse lgecse approved these changes

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisgacsal @lgecse