Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): scan dir asset #1564

Merged
merged 3 commits into from
Apr 15, 2024
Merged

feat(docker): scan dir asset #1564

merged 3 commits into from
Apr 15, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Apr 12, 2024

Description

Currently, the docker provider is only capable of scanning images and containers.

  • Extend docker provider to be able to scan an Asset directory
  • Add e2e test

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner April 12, 2024 14:44
@paralta paralta self-assigned this Apr 12, 2024
@paralta paralta added enhancement New feature or request docker Pull requests that update Docker code go Pull requests that update Go code labels Apr 12, 2024
@paralta paralta changed the title feat(docker): implement dir scan feat(docker): implement dir asset scan Apr 12, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta changed the title feat(docker): implement dir asset scan feat(docker): scan dir asset Apr 12, 2024
ramizpolic
ramizpolic reviewed Apr 12, 2024
View reviewed changes
e2e/dir_scan_test.go Outdated Show resolved Hide resolved
@paralta paralta requested a review from ramizpolic April 15, 2024 09:36
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
ramizpolic
ramizpolic previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @paralta!

@paralta paralta requested a review from ramizpolic April 15, 2024 12:41
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1564-ad51cc534760250d1bdffd9e5e4f78b4dcbd1aa9
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1564-ad51cc534760250d1bdffd9e5e4f78b4dcbd1aa9
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1564-ad51cc534760250d1bdffd9e5e4f78b4dcbd1aa9
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1564-ad51cc534760250d1bdffd9e5e4f78b4dcbd1aa9
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1564-ad51cc534760250d1bdffd9e5e4f78b4dcbd1aa9
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1564-ad51cc534760250d1bdffd9e5e4f78b4dcbd1aa9

@paralta paralta added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 6cfb1bc Apr 15, 2024
34 checks passed
@paralta paralta deleted the docker-scan-dir branch April 15, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

Assignees

@paralta paralta

Labels
docker Pull requests that update Docker code enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paralta @ramizpolic