Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): set directory asset last seen to future time #1653

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(e2e): set directory asset last seen to future time #1653

merged 1 commit into from
May 7, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented May 7, 2024

Description

#1599

Set lastSeen field to 10 min from now so the directory asset is not marked as terminated by the discoverer.

Kudos to @adamtagscherer and @csatib02 for catching this issue 🎉

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta added the bug Something isn't working label May 7, 2024
@paralta paralta self-assigned this May 7, 2024
@paralta paralta requested a review from a team as a code owner May 7, 2024 14:30
@paralta paralta linked an issue May 7, 2024 that may be closed by this pull request
Directory scan test failing intermittently #1599
Closed
2 tasks
@paralta paralta changed the title fix(test): set last seen to future time fix(e2e): set last seen to future time May 7, 2024
@paralta paralta changed the title fix(e2e): set last seen to future time fix(e2e): set directory asset last seen to future time May 7, 2024
ramizpolic
ramizpolic approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! 🚢

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1653-2436cb6db9d009317c5af7a588cd05708fc85f1d
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1653-2436cb6db9d009317c5af7a588cd05708fc85f1d
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1653-2436cb6db9d009317c5af7a588cd05708fc85f1d
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1653-2436cb6db9d009317c5af7a588cd05708fc85f1d
  • ghcr.io/openclarity/vmclarity-plugin-kics-dev:pr1653-2436cb6db9d009317c5af7a588cd05708fc85f1d
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1653-2436cb6db9d009317c5af7a588cd05708fc85f1d
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1653-2436cb6db9d009317c5af7a588cd05708fc85f1d

@paralta paralta added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 83aec53 May 7, 2024
39 of 40 checks passed
@paralta paralta deleted the issue1599-dir-asset-terminated branch May 7, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@csatib02 csatib02 csatib02 left review comments

@lgecse lgecse lgecse approved these changes

Assignees

@paralta paralta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directory scan test failing intermittently
4 participants
@paralta @ramizpolic @csatib02 @lgecse