-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): revisit k8s test env #1681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32f4a02
to
9a2e5c1
Compare
This comment has been minimized.
This comment has been minimized.
9b5e6a8
to
1aceb3d
Compare
This comment has been minimized.
This comment has been minimized.
1aceb3d
to
bc1a07d
Compare
This comment has been minimized.
This comment has been minimized.
bc1a07d
to
f38541c
Compare
This comment has been minimized.
This comment has been minimized.
f38541c
to
62315a9
Compare
This comment has been minimized.
This comment has been minimized.
62315a9
to
add1640
Compare
add1640
to
3e9b60e
Compare
Hey! Your images are ready:
|
ramizpolic
reviewed
May 16, 2024
ramizpolic
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice improvements to e2e!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revisit kubernetes test environment and ensure that tests are successfully running on this provider.
Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist