Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e): revisit k8s test env #1681

Merged
merged 7 commits into from
May 16, 2024
Merged

feat(e2e): revisit k8s test env #1681

merged 7 commits into from
May 16, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented May 15, 2024 •
edited

Description

Revisit kubernetes test environment and ensure that tests are successfully running on this provider.

  • Fix images failing to load by using image name not image ID while saving image to load to node
  • Define new params for the k8s environment
  • Add target in Makefile to run e2e tests on Kubernetes
  • Disable syft analyzer in kubernetes e2e tests due to scan failures when scanning container images Kubernetes scan fails when scanning container images #1666 (second error reported)
  • Enable misconfiguration family for Docker and Kubernetes (this change required an increase in scan timeout)

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta self-assigned this May 15, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta force-pushed the revisit-k8s-test-env branch 3 times, most recently from 9b5e6a8 to 1aceb3d Compare May 15, 2024 15:43
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1681-c5887ec73cd258d2df9aee47e57b598001e17663
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1681-c5887ec73cd258d2df9aee47e57b598001e17663
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1681-c5887ec73cd258d2df9aee47e57b598001e17663
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1681-c5887ec73cd258d2df9aee47e57b598001e17663
  • ghcr.io/openclarity/vmclarity-plugin-kics-dev:pr1681-c5887ec73cd258d2df9aee47e57b598001e17663
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1681-c5887ec73cd258d2df9aee47e57b598001e17663
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1681-c5887ec73cd258d2df9aee47e57b598001e17663

@paralta paralta marked this pull request as ready for review May 16, 2024 10:22
@paralta paralta requested a review from a team as a code owner May 16, 2024 10:22
ramizpolic
ramizpolic approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice improvements to e2e!

@paralta paralta added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit c0c87dc May 16, 2024
38 checks passed
@paralta paralta deleted the revisit-k8s-test-env branch May 16, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

Assignees

@paralta paralta

Labels
kubernetes provider:kubernetes test:e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paralta @ramizpolic