Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue with verifying families errors map #169

Merged
1 commit merged into from
Mar 21, 2023
Merged

fix an issue with verifying families errors map #169

1 commit merged into from
Mar 21, 2023

Conversation

FrimIdan
Copy link
Member

Description

famerr is a map of familiyType --> error, the nil check was wrong causing a successful run to print the following error

Error: failed to run families: map[]

The PR fixes it by checking the length of the map.

Type of Change

[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

@FrimIdan FrimIdan requested a review from a team as a code owner March 21, 2023 05:22
@ghost ghost merged commit f8e4553 into main Mar 21, 2023
@ghost ghost deleted the femerr-issue branch March 21, 2023 08:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant