-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(scanner): propagate context to scanners/analyzers #1741
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
c5f1520
to
d660298
Compare
Note: CIS Docker Benchmark scanner needs to be updated upstream to support contexts being passed when used as a library. It should either be added as part of Config or directly in calling function at https://github.com/Portshift/dockle/blob/4f3b165086b7adbaf853ece809c7c61497bb52d7/pkg/run.go#L44. Without this, we cannot force exit for CIS Docker scanner. This can be done in another PR once there is support for passing ctx in Dockle. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Wouldn't that be a breaking change for the Dockle scanner? Time for our own fork? 😃 A ticket should be created for this anyway if there isn't one already... |
It wont be a breaking change for Dockle. @zsoltkacsandi has a way to address this in a backwards compatible way by making the run function that performs the scan in Dockle public. |
Hey! Your images are ready:
|
Description
Passing context to scanners/analyzers.
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist