-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): enable binary plugin support #1794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsoltkacsandi
force-pushed
the
feat-enable-binary-plugin-support
branch
from
June 13, 2024 11:29
3ec1a8a
to
d0761d8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
akijakya
force-pushed
the
feat-enable-binary-plugin-support
branch
from
June 13, 2024 14:36
37377af
to
1145bcb
Compare
akijakya
reviewed
Jun 17, 2024
ramizpolic
reviewed
Jun 18, 2024
ramizpolic
reviewed
Jun 18, 2024
ramizpolic
reviewed
Jun 19, 2024
zsoltkacsandi
commented
Jun 19, 2024
zsoltkacsandi
commented
Jun 21, 2024
akijakya
force-pushed
the
feat-enable-binary-plugin-support
branch
3 times, most recently
from
June 21, 2024 12:21
c15f4e2
to
67d7ec0
Compare
zsoltkacsandi
commented
Jun 24, 2024
akijakya
force-pushed
the
feat-enable-binary-plugin-support
branch
2 times, most recently
from
June 24, 2024 14:04
bb495ba
to
f0c1a17
Compare
akijakya
reviewed
Jun 24, 2024
akijakya
force-pushed
the
feat-enable-binary-plugin-support
branch
from
June 25, 2024 08:24
830ddfb
to
3d19b6d
Compare
13 tasks
ramizpolic
reviewed
Jun 27, 2024
Signed-off-by: András Jáky <ajaky@cisco.com>
Also make cleanup error log more informative. Signed-off-by: András Jáky <ajaky@cisco.com>
Co-authored-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
akijakya
force-pushed
the
feat-enable-binary-plugin-support
branch
from
June 27, 2024 13:21
b22489c
to
4a1dca1
Compare
This comment has been minimized.
This comment has been minimized.
ramizpolic
reviewed
Jun 28, 2024
ramizpolic
reviewed
Jun 28, 2024
ramizpolic
reviewed
Jun 28, 2024
ramizpolic
reviewed
Jun 28, 2024
13 tasks
Signed-off-by: András Jáky <ajaky@cisco.com>
ramizpolic
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work everyone!!
Hey! Your images are ready:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added top-level
binary_mode
config to the plugin scanner family, and also to the individual plugin scanners, defaulting tofalse
. If the top-levelbinary_mode
config is explicitly specified, it'll overwrite the individual plugin-level ones.If binary mode is enabled, it results in running the scanner plugins without the docker daemon, which means downloading the image (without docker pull), extracting its content to the machine, mounting the necessary directories of the host machine under the plugin filesystem and executing its entrypoint with
chroot
(details are inplugins/runner/internal/runtimehandler/binary/handler.go
).This solution is not intended for using it in production, but for testing purposes in dockerless environments (e.g. CI/CD pipelines).
Type of Change
Checklist