Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ci): improve docs on release flow #1797

Merged
merged 2 commits into from
Jun 17, 2024
Merged

docs(ci): improve docs on release flow #1797

merged 2 commits into from
Jun 17, 2024

Conversation

akijakya
Copy link
Contributor

Description

  • added automatic stashing inmultimod-prerelease make target instead of warning in the docs
  • added additional info and post release steps to the release docs

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@akijakya
feat(release): automatic stashing before release
2f8eef0 
Signed-off-by: András Jáky <ajaky@cisco.com>
@akijakya akijakya self-assigned this Jun 14, 2024
@akijakya akijakya requested a review from a team as a code owner June 14, 2024 13:52
@akijakya akijakya force-pushed the improve-release-docs branch 4 times, most recently from 0f7d3a2 to 3c3c758 Compare June 14, 2024 14:00
@akijakya akijakya changed the title docs(release): improve docs on release flow docs: improve docs on release flow Jun 14, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
ramizpolic
ramizpolic previously approved these changes Jun 14, 2024
View reviewed changes
@akijakya akijakya requested a review from paralta June 17, 2024 08:14
paralta
paralta previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small detail, otherwise looks perfect 👍

RELEASE.md Outdated Show resolved Hide resolved
@akijakya
docs(release): add more notes and steps
e114e1b 
Signed-off-by: András Jáky <ajaky@cisco.com>
@akijakya akijakya dismissed stale reviews from paralta and ramizpolic via e114e1b June 17, 2024 08:22
@akijakya akijakya changed the title docs: improve docs on release flow docs(ci): improve docs on release flow Jun 17, 2024
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1797-eb0bf279f8feef5bb27f1cfcd706500f0323471e
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1797-eb0bf279f8feef5bb27f1cfcd706500f0323471e
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1797-eb0bf279f8feef5bb27f1cfcd706500f0323471e
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1797-eb0bf279f8feef5bb27f1cfcd706500f0323471e
  • ghcr.io/openclarity/vmclarity-plugin-kics-dev:pr1797-eb0bf279f8feef5bb27f1cfcd706500f0323471e
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1797-eb0bf279f8feef5bb27f1cfcd706500f0323471e
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1797-eb0bf279f8feef5bb27f1cfcd706500f0323471e

@akijakya akijakya added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 0295f63 Jun 17, 2024
40 of 41 checks passed
@akijakya akijakya deleted the improve-release-docs branch June 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paralta paralta paralta approved these changes

@ramizpolic ramizpolic ramizpolic left review comments

Assignees

@akijakya akijakya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akijakya @ramizpolic @paralta