Fixes to make trial run work #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that when running on AWS we can create the required resources we need to perform a scan.
ghost
force-pushed
the
fixes_for_trial
branch
2 times, most recently
from
b52cf08
to
2851afd
Compare
AWS requires the user data to be base64 encoded, this commit ensures that we encode the cloud-init data before passing it to the AWS client
ScanScope is an interface containing a pointer passed to the provider, the orcestrator was turning this into a pointer to an interface to a pointer which was preventing the provider from unwrapping it correctly.
Unless we tag the volume with VMClarity the AWS permissions will prevent us from creating it, this is a requirement because we are also prevented from deleting volumes if they don't have the Owner tag so that we can't break user's systems.
Unless these fields are accessible from outside the package its not possible to create a ScanScope with a tag selector because you can only create empty tag structs.
ghost
force-pushed
the
fixes_for_trial
branch
from
2851afd
to
0a89b8c
Compare
akpsgit
approved these changes
Dec 12, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes were required to make the trail run work, and get to the point where VMs and snapshots were being taken on AWS.