Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(ci): add eslint #1822

Merged
merged 1 commit into from
Jun 24, 2024
Merged

ci(ci): add eslint #1822

merged 1 commit into from
Jun 24, 2024

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Jun 19, 2024 •
edited

Description

This PR adds eslint, prettifier and react testing library to the frontend codebase.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added javascript Pull requests that update Javascript code test ci Continious Integration related PRs labels Jun 19, 2024
@adamtagscherer adamtagscherer self-assigned this Jun 19, 2024
@adamtagscherer adamtagscherer changed the title ci: add eslint ci(ci): add eslint Jun 19, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@adamtagscherer adamtagscherer marked this pull request as ready for review June 21, 2024 10:12
@adamtagscherer adamtagscherer requested a review from a team as a code owner June 21, 2024 10:12
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
misi-bp
misi-bp previously approved these changes Jun 21, 2024
View reviewed changes
Copy link

@misi-bp misi-bp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with some parts of the unit test configs set and the configuration opportunities, but if it works, then amen.

csatib02
csatib02 reviewed Jun 22, 2024
View reviewed changes
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about frontend, but I'm in the middle of restructing the whole pipeline for VMClarity, and the only part that can be left intact is the reusable-verification workflow. 😁

.github/workflows/unit-testing-js.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1822-acbb609182912e365a81b4fa8af310a2ba05e380
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1822-acbb609182912e365a81b4fa8af310a2ba05e380
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1822-acbb609182912e365a81b4fa8af310a2ba05e380
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1822-acbb609182912e365a81b4fa8af310a2ba05e380
  • ghcr.io/openclarity/vmclarity-plugin-kics-dev:pr1822-acbb609182912e365a81b4fa8af310a2ba05e380
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1822-acbb609182912e365a81b4fa8af310a2ba05e380
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1822-acbb609182912e365a81b4fa8af310a2ba05e380

csatib02
csatib02 approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(ci)!

gallotamas
gallotamas approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@gallotamas gallotamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

ui/vite.config.ts Show resolved Hide resolved
@adamtagscherer adamtagscherer added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 437d79c Jun 24, 2024
41 checks passed
@adamtagscherer adamtagscherer deleted the add-eslint-frontend branch June 24, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallotamas gallotamas gallotamas approved these changes

@akijakya akijakya akijakya approved these changes

@csatib02 csatib02 csatib02 approved these changes

@misi-bp misi-bp Awaiting requested review from misi-bp

Assignees

@adamtagscherer adamtagscherer

Labels
ci Continious Integration related PRs javascript Pull requests that update Javascript code test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adamtagscherer @gallotamas @akijakya @csatib02 @misi-bp