-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(ci): add eslint #1822
ci(ci): add eslint #1822
Conversation
d3489a5
to
bf6efff
Compare
This comment has been minimized.
This comment has been minimized.
4e18e18
to
1b4ba9b
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with some parts of the unit test configs set and the configuration opportunities, but if it works, then amen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about frontend, but I'm in the middle of restructing the whole pipeline for VMClarity, and the only part that can be left intact is the reusable-verification workflow. 😁
3618cae
to
b6cc1a6
Compare
Hey! Your images are ready:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM(ci)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
Description
This PR adds eslint, prettifier and react testing library to the frontend codebase.
Type of Change
Checklist