-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add summary to package findings #1828
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0327430
to
dd644fe
Compare
UI changes are left to be resolved |
This comment has been minimized.
This comment has been minimized.
c28da84
to
65ebe96
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
UI changes have also been added. The package findings page now looks like this Packages tablePackage detailsThere is a bug left to be fixed when we need to redirect from package details page on click to "Package Vulnerabilities" to related package vulnerabilities table view. @gallotamas is looking into this |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey! Your images are ready:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 the backend part looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds summary field to findings. Registers a new processor for findings to calculate vulnerability severity count for applicable finding types (i.e. only for packages).
Closes #1040
Type of Change
Checklist