Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add summary to package findings #1828

Merged
merged 16 commits into from
Jun 27, 2024
Merged

Conversation

ramizpolic
Copy link
Member

@ramizpolic ramizpolic commented Jun 23, 2024

Description

Adds summary field to findings. Registers a new processor for findings to calculate vulnerability severity count for applicable finding types (i.e. only for packages).

Closes #1040

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ramizpolic ramizpolic requested a review from a team as a code owner June 23, 2024 09:26
@ramizpolic ramizpolic self-assigned this Jun 23, 2024
@ramizpolic ramizpolic marked this pull request as draft June 23, 2024 09:26
@ramizpolic ramizpolic added component:api Issues related to API component:ui Issues related to UI/Frontend component:orchestrator enhancement New feature or request labels Jun 23, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ramizpolic ramizpolic marked this pull request as ready for review June 24, 2024 17:51
@ramizpolic
Copy link
Member Author

UI changes are left to be resolved

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ramizpolic
Copy link
Member Author

UI changes have also been added. The package findings page now looks like this

Packages table

image

Package details

image

There is a bug left to be fixed when we need to redirect from package details page on click to "Package Vulnerabilities" to related package vulnerabilities table view. @gallotamas is looking into this

This comment has been minimized.

This comment has been minimized.

Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1828-4238a27a14aec586cde7409df0c3387973ddafa2
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1828-4238a27a14aec586cde7409df0c3387973ddafa2
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1828-4238a27a14aec586cde7409df0c3387973ddafa2
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1828-4238a27a14aec586cde7409df0c3387973ddafa2
  • ghcr.io/openclarity/vmclarity-plugin-kics-dev:pr1828-4238a27a14aec586cde7409df0c3387973ddafa2
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1828-4238a27a14aec586cde7409df0c3387973ddafa2
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1828-4238a27a14aec586cde7409df0c3387973ddafa2

Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 the backend part looks good to me

Copy link
Contributor

@adamtagscherer adamtagscherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ramizpolic ramizpolic added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 8e60279 Jun 27, 2024
41 checks passed
@ramizpolic ramizpolic deleted the feat/package-vulns-count branch June 27, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api Issues related to API component:orchestrator component:ui Issues related to UI/Frontend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include vulnerability data in package findings
4 participants