-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): generate frontend oapi code #1843
Conversation
d54069e
to
6011c32
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
6011c32
to
7fd32d0
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
e699566
to
395b30f
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com> Co-authored-by: Adam Tagscherer <atagsche@cisco.com>
9a6bc58
to
6088ab2
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
ui/src/components/WrappingTextBoxWithEllipsis/wrapping-text-box-with-ellipsis.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 important things that are missing from this PR.
- VMClarity has 2 APIs that are used from the UI and we are only generating code to one of them here. Please add code generation for the UI Backend as well: https://github.com/openclarity/vmclarity/blob/main/uibackend/openapi.yaml
- we should add npm commands to (re)generate code while working on the frontend. See my comment above for more details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small small issue but overall Looks Good To Me! {Rocket}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job! 🎉
Description
Generate frontend SDK.
Added UI related makefile targets.
Updated docs.
Changing to react queries will be in a follow-up PR.
Type of Change
Checklist