feat(api): generate frontend oapi code #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csatib02
force-pushed
the
e2e-type-safe-apis
branch
2 times, most recently
from
d54069e
to
6011c32
Compare
csatib02
added
enhancement
Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
force-pushed
the
e2e-type-safe-apis
branch
from
6011c32
to
7fd32d0
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
force-pushed
the
e2e-type-safe-apis
branch
2 times, most recently
from
e699566
to
395b30f
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com> Co-authored-by: Adam Tagscherer <atagsche@cisco.com>
csatib02
force-pushed
the
e2e-type-safe-apis
branch
from
9a6bc58
to
6088ab2
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
adamtagscherer
commented
Jul 23, 2024
adamtagscherer
commented
Jul 23, 2024
adamtagscherer
commented
Jul 23, 2024
ui/src/components/WrappingTextBoxWithEllipsis/wrapping-text-box-with-ellipsis.scss
Outdated
Show resolved
Hide resolved
gallotamas
reviewed
Jul 23, 2024
gallotamas
requested changes
Jul 23, 2024
There was a problem hiding this comment.
There are 2 important things that are missing from this PR.
- VMClarity has 2 APIs that are used from the UI and we are only generating code to one of them here. Please add code generation for the UI Backend as well: https://github.com/openclarity/vmclarity/blob/main/uibackend/openapi.yaml
- we should add npm commands to (re)generate code while working on the frontend. See my comment above for more details
gallotamas
reviewed
Jul 23, 2024
csatib02
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate frontend SDK.
Added UI related makefile targets.
Updated docs.
Changing to react queries will be in a follow-up PR.
Type of Change
Checklist