Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): make reportFormats param configurable #1867

Merged
merged 2 commits into from
Jul 8, 2024
Merged

feat(plugin): make reportFormats param configurable #1867

merged 2 commits into from
Jul 8, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Jul 5, 2024 •
edited

Description

  • Makes the ReportFormats field configurable.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@csatib02 csatib02 added the enhancement New feature or request label Jul 5, 2024
@csatib02 csatib02 self-assigned this Jul 5, 2024
@csatib02 csatib02 added the go Pull requests that update Go code label Jul 5, 2024
@csatib02 csatib02 changed the title feat(kics): make reportFormats param configurable feat(plugin): make reportFormats param configurable Jul 5, 2024
@csatib02 csatib02 force-pushed the feat/make-reportformats-configurable branch 3 times, most recently from 59b10f8 to b2cac25 Compare July 5, 2024 15:18
@csatib02
feat(kics): make reportFormats param configurable
86e8f16 
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 force-pushed the feat/make-reportformats-configurable branch from b2cac25 to 86e8f16 Compare July 5, 2024 15:28
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@csatib02 csatib02 marked this pull request as ready for review July 5, 2024 15:59
@csatib02 csatib02 requested a review from a team as a code owner July 5, 2024 15:59
ramizpolic
ramizpolic requested changes Jul 5, 2024
View reviewed changes
e2e/kics_output_test.go Outdated Show resolved Hide resolved
plugins/store/kics/main.go Outdated Show resolved Hide resolved
plugins/store/kics/main.go Show resolved Hide resolved
@csatib02 csatib02 requested a review from ramizpolic July 6, 2024 10:08
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@csatib02 csatib02 force-pushed the feat/make-reportformats-configurable branch 3 times, most recently from b2a009a to b24f3ae Compare July 6, 2024 11:37
@csatib02 csatib02 force-pushed the feat/make-reportformats-configurable branch from b24f3ae to f14d282 Compare July 6, 2024 11:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1867-98b0a7c0ee5c40ad8b3202d992ac754b4d45dd2c
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1867-98b0a7c0ee5c40ad8b3202d992ac754b4d45dd2c
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1867-98b0a7c0ee5c40ad8b3202d992ac754b4d45dd2c
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1867-98b0a7c0ee5c40ad8b3202d992ac754b4d45dd2c
  • ghcr.io/openclarity/vmclarity-plugin-kics-dev:pr1867-98b0a7c0ee5c40ad8b3202d992ac754b4d45dd2c
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1867-98b0a7c0ee5c40ad8b3202d992ac754b4d45dd2c
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1867-98b0a7c0ee5c40ad8b3202d992ac754b4d45dd2c

ramizpolic
ramizpolic approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @csatib02!

@csatib02 csatib02 added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 2feca38 Jul 8, 2024
41 checks passed
@csatib02 csatib02 deleted the feat/make-reportformats-configurable branch July 8, 2024 09:50
@ramizpolic ramizpolic mentioned this pull request Jul 8, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

Assignees

@csatib02 csatib02

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@csatib02 @ramizpolic