Update VMClarity CLI docker build to use vmclarity-tools-base #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the VMClarity Dockerfile.cli to use vmclarity-tools-base as the final base image instead of alpine. The vmclarity-tools-base includes the tools required to perform the scans, like gitleaks, lynis etc preinstalled so that we don't need to install them in every CI run for VMClarity.
FrimIdan
reviewed
Dec 8, 2022
This allows for developers building locally to override the standard vmclarity-tools-base image for testing/development without access to the ghcr.io registry.
ghost
requested a review
from
FrimIdan
approved these changes
Dec 8, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the VMClarity Dockerfile.cli to use vmclarity-tools-base as the final base image instead of alpine. The vmclarity-tools-base includes the tools required to perform the scans, like gitleaks, lynis etc preinstalled so that we don't need to install them in every CI run for VMClarity.