-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): add benchmarking #1903
Conversation
351bf8d
to
0c85152
Compare
e2e/benchmark_test.go
Outdated
} | ||
|
||
rows = append(rows, []string{ | ||
fmt.Sprintf("%s (%s)", famType, n.scannerName[famType]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fmt.Sprintf("%s (%s)", famType, n.scannerName[famType]), | |
fmt.Sprintf("%s/%s", famType, n.scannerName[famType]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes it clearer that there is a subtask running, while we can also have a breakdown of the family and overall scan too, for example:
Family/Scanner | Start time | End time | Findings | Total time |
---|---|---|---|---|
plugins/kics | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | - | 18s |
plugins/* | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | 23 | 18s |
malware/yara | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | - | 18s |
malware/* | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | 0 | 18s |
Scan summary | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | 23 | 18s |
Note: family/*
indicate total time to execute a specific family, family/scanner
indicate how long specific scanner within a family took.
For family summary, the start time is the time of the earliest family scanner to start, while end time is the time of the last family scanner to finish.
For overall summary, the start and end times are the same, but across all notifications.
59071c3
to
999e105
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
999e105
to
449d130
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com> refactor(benchmark): refactor from e2e to normal go test Signed-off-by: Bence Csati <bcsati@cisco.com>
aa4d5c7
to
1ed3286
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Closing due to unification, can be resumed in the new repo once everything is ready |
Description
Type of Change
Checklist