feat(e2e): add benchmarking #1903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csatib02
added
enhancement
csatib02
force-pushed
the
feat/add-benchmarking
branch
2 times, most recently
from
351bf8d
to
0c85152
Compare
ramizpolic
reviewed
Jul 15, 2024
e2e/benchmark_test.go
Outdated
| } | ||
|
|
||
| rows = append(rows, []string{ | ||
| fmt.Sprintf("%s (%s)", famType, n.scannerName[famType]), |
There was a problem hiding this comment.
Suggested change
| fmt.Sprintf("%s (%s)", famType, n.scannerName[famType]), | |
| fmt.Sprintf("%s/%s", famType, n.scannerName[famType]), |
There was a problem hiding this comment.
makes it clearer that there is a subtask running, while we can also have a breakdown of the family and overall scan too, for example:
| Family/Scanner | Start time | End time | Findings | Total time |
|---|---|---|---|---|
| plugins/kics | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | - | 18s |
| plugins/* | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | 23 | 18s |
| malware/yara | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | - | 18s |
| malware/* | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | 0 | 18s |
| Scan summary | 2024-07-15 08:44:32 | 2024-07-15 08:44:49 | 23 | 18s |
Note: family/* indicate total time to execute a specific family, family/scanner indicate how long specific scanner within a family took.
For family summary, the start time is the time of the earliest family scanner to start, while end time is the time of the last family scanner to finish.
For overall summary, the start and end times are the same, but across all notifications.
csatib02
force-pushed
the
feat/add-benchmarking
branch
2 times, most recently
from
59071c3
to
999e105
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
force-pushed
the
feat/add-benchmarking
branch
from
999e105
to
449d130
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com> refactor(benchmark): refactor from e2e to normal go test Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
force-pushed
the
feat/add-benchmarking
branch
from
aa4d5c7
to
1ed3286
Compare
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
|
Closing due to unification, can be resumed in the new repo once everything is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist