This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
Implement proper queue for reconciling logic #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
This queue ensure that we don't requeue items which are already queued, and ensures that if something is already queued, the queue isn't replaced by the next poll reseting the ordering.
akpsgit
reviewed
Mar 28, 2023
akpsgit
reviewed
Mar 28, 2023
Also add doc comments for all the functions and interfaces for Enqueuer and Dequeuer to allow alternative implementations to be passed to the Poller/Reconciler.
akpsgit
approved these changes
Mar 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This queue ensures that we don't requeue items which are already queued, and ensures that if something is already queued, the queue isn't replaced by the next poll reseting the ordering.
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist