Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gitleaks secret scanner #20

Merged
merged 8 commits into from
Dec 15, 2022
Merged

add gitleaks secret scanner #20

merged 8 commits into from
Dec 15, 2022

Conversation

fishkerez
Copy link
Contributor

No description provided.

@fishkerez fishkerez changed the title add gitleaks Draft: add gitleaks Dec 12, 2022
@fishkerez fishkerez requested review from FrimIdan and a user and removed request for FrimIdan and a user December 12, 2022 10:28
@fishkerez fishkerez self-assigned this Dec 12, 2022
ghost
ghost suggested changes Dec 12, 2022
View reviewed changes
.families.yaml Outdated Show resolved Hide resolved
.families.yaml Outdated Show resolved Hide resolved
.families.yaml Outdated Show resolved Hide resolved
cli/cmd/root.go Outdated Show resolved Hide resolved
shared/pkg/families/sbom/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/result.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
FrimIdan
FrimIdan reviewed Dec 12, 2022
View reviewed changes
.families.yaml Outdated Show resolved Hide resolved
shared/pkg/families/sbom/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/config.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/result.go Show resolved Hide resolved
FrimIdan
FrimIdan reviewed Dec 14, 2022
View reviewed changes
config.yaml Outdated Show resolved Hide resolved
shared/pkg/families/secrets/family.go Outdated Show resolved Hide resolved
shared/pkg/families/secrets/gitleaks/gitleaks.go Outdated Show resolved Hide resolved
ghost
ghost reviewed Dec 14, 2022
View reviewed changes
config.yaml Show resolved Hide resolved
ghost
ghost suggested changes Dec 14, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty close, a few more comments and then we'll be there

ghost
ghost reviewed Dec 15, 2022
View reviewed changes
.families.yaml Outdated Show resolved Hide resolved
ghost
ghost previously approved these changes Dec 15, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all its looking good, just needs to get through CI. I have one comment you might want to address to remove your personal info from the .families.yaml, but thats up to you, I think it would be best to solve it

ghost
ghost previously approved these changes Dec 15, 2022
View reviewed changes
FrimIdan
FrimIdan previously approved these changes Dec 15, 2022
View reviewed changes
@fishkerez fishkerez changed the title Draft: add gitleaks add gitleaks secret scanner Dec 15, 2022
@fishkerez fishkerez merged commit 736bd8f into main Dec 15, 2022
@fishkerez fishkerez deleted the add-gitleaks-as-scanner branch December 15, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrimIdan FrimIdan FrimIdan left review comments

Assignees

@fishkerez fishkerez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fishkerez @FrimIdan