-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stopping Scans to Orchestrator #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f04e658
to
416bedd
Compare
ghost
suggested changes
Apr 3, 2023
461fc76
to
a326e35
Compare
4fe5cb4
to
2bc98cf
Compare
ghost
suggested changes
Apr 13, 2023
355b6e9
to
29edd4d
Compare
The PR is ready for review. I have added a test plan with manual steps to verify the functionality to abort running scans. |
9aff99b
to
8ef78dc
Compare
ghost
previously approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking great, I've got a couple of suggestions, happy to punt them to later.
akpsgit
reviewed
Apr 19, 2023
akpsgit
reviewed
Apr 19, 2023
akpsgit
reviewed
Apr 19, 2023
akpsgit
reviewed
Apr 19, 2023
Set Scan status to Failed even if no related ScanResults need to be updated during reconciling aborted scans.
This part of the code is going to be refactored very soon so it is safe to disable gocognit linter here.
akpsgit
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ScanWatcher
to look up for Scans which status has changed toAborted
and updated all the correspondingScanResult
status toABORTED
so the Scanner Worker and the CLI could detect cancellation events.ScanResult
state is changed toAborted
.Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist
Test Plan
Manual steps to test aborting ongoing scans in live environment.
Expand
Scan configuration
Create Scan Configuration file
Apply Scan Configuration to API
Get Scan Configuration object from API
Start Scan
Start Scan using Scan Config
Get ongoing Scan from API using ScanConfig id
Abort Scan in progress