Pull results on top of main. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merged Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
fishkerez
reviewed
Dec 17, 2022
ghost
reviewed
Jan 5, 2023
| List length must be lower or equal to pageSize. | ||
| items: | ||
| $ref: '#/components/schemas/TargetScanResult' | ||
| $ref: '#/components/schemas/TargetScanResults' |
There was a problem hiding this comment.
nit: just a naming thing but this should probably be just "ScanResults" now
akpsgit
reviewed
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new PR on top of main branch because of a rebase accident and I closed #23
This PR contains all of the last changes and replace the POST and PUT response ScanResultsSummary with Scanresults from the openapi.yaml (this commit was missed before)
According to @sambetts-cisco