Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AWS Scanner VM InstanceType configurable #251

Merged
1 commit merged into from
Apr 14, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2023

Description

This exposes a new environment variable configuration AWS_INSTANCE_TYPE for the orchestrator which configures the instance type to use for the scanner VMs. It defaults to t2.large.

A new parameter has been added to the cloud formation to allow user's to choose which instance type they wish to use at install time.

Type of Change

[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ghost ghost self-requested a review as a code owner April 14, 2023 09:47
This exposes a new environment variable configuration AWS_INSTANCE_TYPE
for the orchestrator which configures the instance type to use for the
scanner VMs. It defaults to t2.large.

A new parameter has been added to the cloud formation to allow user's to
choose which instance type they wish to use at install time.
@ghost ghost force-pushed the scanner_instance_type branch from b8c606e to 52bfad3 Compare April 14, 2023 09:47
Copy link
Member

@pbalogh-sa pbalogh-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost ghost merged commit f7b50f5 into main Apr 14, 2023
@ghost ghost deleted the scanner_instance_type branch April 14, 2023 12:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants