Separate Ingress rules from Scanner SG in cloudformation #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalogh-sa
previously approved these changes
Apr 14, 2023
This PR removes the SSH ingress rule from the ScannerSecurityGroup to prevent circular dependencies between the created resources in AWS. Without this change its not possible to delete the SecurityGroups because they have rules which reference each other.
ghost
force-pushed
the
fix_security_group_dep
branch
from
84cb0aa
to
136e4cb
Compare
pbalogh-sa
approved these changes
Apr 14, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the SSH ingress rule from the ScannerSecurityGroup to prevent circular dependencies between the created resources in AWS. Without this change its not possible to delete the SecurityGroups because they have rules which reference each other.
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist