-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to configure timeout for Scans #273
Conversation
26f8e7e
to
94219fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should drop the TimeoutTime logic now, its not great from an API UX perspective and StartTime + TimeoutSeconds satisfies the same flow in the code.
Agreed. It felt weird to me as well. I thought that having the |
Through the scan configuration a maximum number of seconds (timeoutSeconds) can be configured. When a scan is triggered from a configuration this number of seconds will be added to the start time and saved as timeoutTime on the Scan object. If while the Scan is running the current time exceeds the timeoutTime then the scan is automatically failed and any remaining AssetScans will be terminated. If no timeoutTime is provided on a scan it will be automatically timed out 48 hours after the start time of the scan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @chrisgacsal
Description
Through the scan configuration a maximum number of seconds (
timeoutSeconds
) can be configured.When a scan is triggered from a configuration this number of seconds will be added to the start time and saved as
timeoutTime
on the Scan object.If while the Scan is running the current time exceeds the
timeoutTime
then the scan is automatically failed and any remaining AssetScans will be terminated.If no
timeoutTime
is provided on a scan it will be automatically timed out 48 hours after the start time of the scan.Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist