Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch scanconfigs #29

Merged
merged 22 commits into from
Jan 22, 2023
Merged

Watch scanconfigs #29

merged 22 commits into from
Jan 22, 2023

Conversation

pbalogh-sa
Copy link
Member

No description provided.

@pbalogh-sa pbalogh-sa self-assigned this Jan 13, 2023
FrimIdan

This comment was marked as outdated.

Sign in to view

ghost
ghost previously requested changes Jan 17, 2023
View reviewed changes
runtime_scan/pkg/orchestrator/configwatcher/scanconfig_watcher.go Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/configwatcher/scanconfig_watcher.go Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/configwatcher/scanconfig_watcher.go Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/configwatcher/scanconfig_watcher.go Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/configwatcher/scanconfig_watcher.go Show resolved Hide resolved
runtime_scan/pkg/orchestrator/scheduler/scheduler.go Outdated

func (s *Scheduler) scheduleNewScans(scanConfigMap *map[string]models.ScanConfig) error {
for id, scanConfig := range *scanConfigMap {
scanConfig := scanConfig
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't use the same variable name here though we risk variable shadowing

runtime_scan/pkg/orchestrator/scheduler/scheduler.go Outdated Show resolved Hide resolved
runtime_scan/pkg/orchestrator/orchestrator.go Show resolved Hide resolved
fishkerez
fishkerez reviewed Jan 19, 2023
View reviewed changes
backend/pkg/config/config.go Show resolved Hide resolved
runtime_scan/pkg/config/config.go Outdated Show resolved Hide resolved
@ghost ghost dismissed their stale review January 20, 2023 09:43

All changes requested handled, will re-review on next update

@pbalogh-sa
initial commit
a0955e5 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
gst
21ba52b 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
updates
3700ddd 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
update
7bb05e4 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
fix
3cadcca 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
update check interval
a866246 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
updated
78af69a 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
review
7256625 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
run gen api
3e481d9 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
update resttodb convert after page and PageSize params modification
41d6c44 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
review
6160b98 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
review
7e40e25 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
review
c34f0bc 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
fix missing license header
529bab8
@pbalogh-sa
fix missing target ID
778d868
@pbalogh-sa
drop wrapper fn
98c880b
@pbalogh-sa
fix scanID
24d97f8
@pbalogh-sa
use net.oinHostPort
7b1a733 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
update orchestrator config to use backend endpoint instead of port an…
68e40c0 
…d host

Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@pbalogh-sa
fixes after rebase
9bba943 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
pbalogh-sa and others added 2 commits January 20, 2023 16:59
@pbalogh-sa
fix schedule type
d769692 
Signed-off-by: Peter Balogh <p.balogh.sa@gmail.com>
@akpsgit
typo
fb46900
@akpsgit akpsgit merged commit a9c6502 into main Jan 22, 2023
@akpsgit akpsgit deleted the watch-scanconfig branch January 22, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrimIdan FrimIdan FrimIdan left review comments

@fishkerez fishkerez fishkerez left review comments

@akpsgit akpsgit akpsgit approved these changes

Assignees

@pbalogh-sa pbalogh-sa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbalogh-sa @akpsgit @FrimIdan @fishkerez