Fix issue with double counting in findings trends graph #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
|
lgtm, I will let @galiail approve the ui changes |
akpsgit
reviewed
May 17, 2023
This commit fixes an issue where the queries building the data for the findings trends graph accidentily counted some findings twice by filtering on a range instead of the specific point in time shown on the graph. The implementation (backend and UI) for the widget has been changed to generate and handle a list of specific times between the start and endtimes requested instead of small ranges, and then calculate the findings count for that specific point in time.
akpsgit
approved these changes
May 17, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes an issue where the queries building the data for the findings trends graph accidentily counted some findings twice by filtering on a range instead of the specific point in time shown on the graph.
The implementation (backend and UI) for the widget has been changed to generate and handle a list of specific times between the start and endtimes requested instead of small ranges, and then calculate the findings count for that specific point in time.
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist