Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added operationId for operationObjects in OpenAPI specs #323

Merged
merged 1 commit into from
May 26, 2023

Conversation

mirac-cisco
Copy link
Contributor

Description

api/openapi.yaml was missing operationId attributes for operationsObjects (documentation here).
oapi-codegen seems to ignore this and generates the operationId's if they are absent. I added the identifiers to match the ones generated by oapi-codegen, so there are no changes in the generated client/model/server.gen.go. I confirmed this by running make api and diffing the files.

Code generation tested with openapi-python-generator.

Also ran the make build and make test to check for any failures, but no functionality has been changed.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@mirac-cisco mirac-cisco requested a review from a team as a code owner May 25, 2023 13:57
@chrisgacsal chrisgacsal added this pull request to the merge queue May 26, 2023
Merged via the queue into openclarity:main with commit 199748f May 26, 2023
@mirac-cisco mirac-cisco deleted the chore/update-openapi branch June 23, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants